Worked in the reviewer's comments#80
Merged
BrapiCoordinatorSelby merged 1 commit intoplantbreeding:mainfrom Apr 17, 2025
Merged
Worked in the reviewer's comments#80BrapiCoordinatorSelby merged 1 commit intoplantbreeding:mainfrom
BrapiCoordinatorSelby merged 1 commit intoplantbreeding:mainfrom
Conversation
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
[ci skip] This build is based on 0de0c7a. This commit was created by the following CI build and job: https://github.com/plantbreeding/BrAPI-Manuscript2/commit/0de0c7a9d5b560aeafe6b37bdc9e09ac30999437/checks https://github.com/plantbreeding/BrAPI-Manuscript2/actions/runs/14522627236
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
[ci skip] This build is based on 0de0c7a. This commit was created by the following CI build and job: https://github.com/plantbreeding/BrAPI-Manuscript2/commit/0de0c7a9d5b560aeafe6b37bdc9e09ac30999437/checks https://github.com/plantbreeding/BrAPI-Manuscript2/actions/runs/14522627236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @BrapiCoordinatorSelby,
I worked in the comment and suggestion provided by the reviewer as found in the shared Google Doc; see the section headline "Page 25 of 33, GraphQL Data-warehouse", please.
I think by using the reviewer's suggestion itself, we maximize the changes of getting accepted. And the suggestion is sound and adds clarity.